Skip to content

[PR #10951/12ff66d backport][3.11] Fix AsyncResolver not using the loop argument #10954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025

fixes #10787

(cherry picked from commit 12ff66d)

@bdraco bdraco changed the title [3.12] Fix AsyncResolver not using the loop argument (#10951) [3.11] Fix AsyncResolver not using the loop argument (#10951) May 22, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 22, 2025
@bdraco bdraco changed the title [3.11] Fix AsyncResolver not using the loop argument (#10951) [PR #10951/12ff66d backport][3.11] Fix AsyncResolver not using the loop argument May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (ab84403) to head (ecbeb02).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11   #10954      +/-   ##
==========================================
+ Coverage   96.28%   98.08%   +1.80%     
==========================================
  Files         124      126       +2     
  Lines       37638    37743     +105     
  Branches     2359     4568    +2209     
==========================================
+ Hits        36241    37022     +781     
+ Misses       1133      544     -589     
+ Partials      264      177      -87     
Flag Coverage Δ
CI-GHA 97.97% <100.00%> (+1.68%) ⬆️
OS-Linux 97.67% <100.00%> (?)
OS-Windows 94.65% <25.00%> (?)
OS-macOS 96.80% <100.00%> (+0.51%) ⬆️
Py-3.10.11 96.67% <100.00%> (?)
Py-3.10.17 97.18% <100.00%> (?)
Py-3.11.12 97.24% <100.00%> (?)
Py-3.11.9 96.74% <100.00%> (?)
Py-3.12.10 97.75% <100.00%> (?)
Py-3.13.3 97.73% <100.00%> (?)
Py-3.9.13 96.57% <100.00%> (+0.29%) ⬆️
Py-3.9.22 97.13% <100.00%> (?)
Py-pypy7.3.16 96.65% <100.00%> (?)
VM-macos 96.80% <100.00%> (+0.51%) ⬆️
VM-ubuntu 97.67% <100.00%> (?)
VM-windows 94.65% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10954 will not alter performance

Comparing patchback/backports/3.11/12ff66d5312bd9df894e506f8802b133d0293b91/pr-10951 (ecbeb02) with 3.11 (ab84403)

Summary

✅ 55 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review May 22, 2025 22:51
@bdraco bdraco requested review from webknjaz and asvetlov as code owners May 22, 2025 22:51
@bdraco bdraco merged commit ab7ba38 into 3.11 May 22, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/12ff66d5312bd9df894e506f8802b133d0293b91/pr-10951 branch May 22, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant