Skip to content

[PR #10956/5dcb36a4 backport][3.12] Fix some missing connector closes in tests #10957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 22, 2025

This is a backport of PR #10956 as merged into master (5dcb36a).

SSIA

Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10957 will not alter performance

Comparing patchback/backports/3.12/5dcb36a4083507a1deefa0af85b3924db624e4a4/pr-10956 (88b747f) with 3.12 (2eb3f6c)

Summary

✅ 59 untouched benchmarks

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.16%. Comparing base (b5a061b) to head (88b747f).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/test_proxy_functional.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10957      +/-   ##
==========================================
- Coverage   98.17%   98.16%   -0.01%     
==========================================
  Files         130      130              
  Lines       39749    39754       +5     
  Branches     2241     2241              
==========================================
+ Hits        39022    39025       +3     
- Misses        555      557       +2     
  Partials      172      172              
Flag Coverage Δ
CI-GHA 98.05% <60.00%> (-0.01%) ⬇️
OS-Linux 97.77% <60.00%> (-0.01%) ⬇️
OS-Windows 95.26% <60.00%> (-0.01%) ⬇️
OS-macOS 96.94% <60.00%> (-0.01%) ⬇️
Py-3.10.11 96.83% <60.00%> (-0.01%) ⬇️
Py-3.10.17 97.38% <60.00%> (-0.01%) ⬇️
Py-3.11.12 97.47% <60.00%> (-0.01%) ⬇️
Py-3.11.9 96.93% <60.00%> (-0.01%) ⬇️
Py-3.12.10 97.83% <60.00%> (-0.01%) ⬇️
Py-3.13.3 97.83% <60.00%> (+<0.01%) ⬆️
Py-3.9.13 96.72% <60.00%> (-0.01%) ⬇️
Py-3.9.22 97.22% <60.00%> (-0.04%) ⬇️
Py-pypy7.3.16 83.74% <60.00%> (-2.86%) ⬇️
VM-macos 96.94% <60.00%> (-0.01%) ⬇️
VM-ubuntu 97.77% <60.00%> (-0.01%) ⬇️
VM-windows 95.26% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) May 22, 2025 23:50
@bdraco bdraco merged commit 6ccd3d5 into 3.12 May 22, 2025
32 of 33 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/5dcb36a4083507a1deefa0af85b3924db624e4a4/pr-10956 branch May 22, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant