Skip to content

[PR #10959/cc234c6d backport][3.12] Change ClientSession middlewares default to be an empty tuple #10960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 23, 2025

This is a backport of PR #10959 as merged into master (cc234c6).

This will avoid one breaking change in 4.0 in when we make the other change in #10890 and remove if effective_middlewares:

closes #10905

@bdraco bdraco added this to the 3.12 milestone May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (6ccd3d5) to head (1e2d633).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10960   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files         130      130           
  Lines       39754    39754           
  Branches     2241     2241           
=======================================
  Hits        39025    39025           
  Misses        557      557           
  Partials      172      172           
Flag Coverage Δ
CI-GHA 98.05% <ø> (ø)
OS-Linux 97.77% <ø> (ø)
OS-Windows 95.27% <ø> (+<0.01%) ⬆️
OS-macOS 96.94% <ø> (ø)
Py-3.10.11 96.84% <ø> (+<0.01%) ⬆️
Py-3.10.17 97.38% <ø> (+<0.01%) ⬆️
Py-3.11.12 97.47% <ø> (ø)
Py-3.11.9 96.93% <ø> (ø)
Py-3.12.10 97.83% <ø> (ø)
Py-3.13.3 97.83% <ø> (+0.01%) ⬆️
Py-3.9.13 96.72% <ø> (+<0.01%) ⬆️
Py-3.9.22 97.25% <ø> (+0.02%) ⬆️
Py-pypy7.3.16 88.05% <ø> (-1.17%) ⬇️
VM-macos 96.94% <ø> (ø)
VM-ubuntu 97.77% <ø> (ø)
VM-windows 95.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Performance Report

Merging #10960 will not alter performance

Comparing patchback/backports/3.12/cc234c6df051228245dd01d0ec638ea7067eeb26/pr-10959 (1e2d633) with 3.12 (6ccd3d5)

Summary

✅ 59 untouched benchmarks

@bdraco bdraco merged commit 2c55e88 into 3.12 May 23, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/cc234c6df051228245dd01d0ec638ea7067eeb26/pr-10959 branch May 23, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant