add example of setting network interface in custom socket creation #10962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10962 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 129 129
Lines 39541 39541
Branches 2185 2185
=======================================
+ Hits 39051 39054 +3
+ Misses 342 339 -3
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10962 will not alter performanceComparing Summary
|
bdraco
added
the
backport-3.12
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
approved these changes
May 23, 2025
|
Thanks @Cycloctane |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10966 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 23, 2025
…10962) Co-authored-by: J. Nick Koston <[email protected]> (cherry picked from commit 84decfe)
5 tasks
bdraco
added a commit
that referenced
this pull request
May 23, 2025
…terface in custom socket creation (#10966) Co-authored-by: Cycloctane <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> closes #7132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Some users may want to specific network interface used by client session (as in #6383 and #7132 ). In aiohttp 3.12, this can be done more gracefully with
socket_factoryinTCPConnector. I think it would be helpful to mention it insocket_factory's documentation as one of its common usecases.Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
closes #7132
Checklist
CONTRIBUTORS.txtCHANGES/folder