-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix WebSocketResponse.prepared
not correctly reflect the WebSocket's prepared state
#10971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WebSocketResponse.prepared
not correctly reflect the WebSocket's prepared state
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10971 +/- ##
==========================================
+ Coverage 98.10% 98.77% +0.66%
==========================================
Files 129 129
Lines 39541 39620 +79
Branches 2185 2186 +1
==========================================
+ Hits 38792 39133 +341
+ Misses 591 339 -252
+ Partials 158 148 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10971 will not alter performanceComparing Summary
|
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10982 🤖 @patchback |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10983 🤖 @patchback |
…not correctly reflect the WebSocket's prepared state (#10982) Co-authored-by: J. Nick Koston <[email protected]> fixes #6009
…not correctly reflect the WebSocket's prepared state (#10983) Co-authored-by: J. Nick Koston <[email protected]> fixes #6009
This PR fixes an issue where the
WebSocketResponse.prepared
property did not correctly reflect the WebSocket's prepared state, particularly during timeout scenarios.Previously, the
prepared
property inherited fromStreamResponse
only checked for_payload_writer
, but in WebSocket timeout scenarios, the_writer
could be set while_payload_writer
remainedNone
, leading to incorrect state reporting.Changes
prepared
property toWebSocketResponse
that checks for_writer
instead of relying on the parent class's_payload_writer
checkprepare()
method to prevent double preparation when_writer
is already setfixes #6009