-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add missing prepared method for WebSocketResponse to docs #10988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I forgot to add the reference
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10988 +/- ##
==========================================
+ Coverage 97.89% 98.77% +0.87%
==========================================
Files 127 129 +2
Lines 39557 39624 +67
Branches 2176 2187 +11
==========================================
+ Hits 38726 39137 +411
+ Misses 672 339 -333
+ Partials 159 148 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10988 will not alter performanceComparing Summary
|
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10989 🤖 @patchback |
(cherry picked from commit 54f1a84)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10990 🤖 @patchback |
(cherry picked from commit 54f1a84)
…ebSocketResponse to docs (#10990) Co-authored-by: J. Nick Koston <[email protected]>
…ebSocketResponse to docs (#10989) Co-authored-by: J. Nick Koston <[email protected]>
We now override this method so we should document it. I should have used :py:attr:
~aiohttp.web.WebSocketResponse.prepared