Skip to content

[PR #11106/cfb9931 backport][3.13] Fix cookies with duplicate names being lost when updating cookie jar #11109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 1, 2025

(cherry picked from commit cfb9931)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 1, 2025
Copy link

codecov bot commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (b2242d6) to head (146b917).
Report is 1 commits behind head on 3.13.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##             3.13   #11109    +/-   ##
========================================
  Coverage   98.25%   98.25%            
========================================
  Files         130      130            
  Lines       41777    41999   +222     
  Branches     2293     2300     +7     
========================================
+ Hits        41046    41267   +221     
  Misses        557      557            
- Partials      174      175     +1     
Flag Coverage Δ
CI-GHA 98.14% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.88% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.50% <100.00%> (+0.02%) ⬆️
OS-macOS 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.86% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.11.12 97.55% <100.00%> (+0.05%) ⬆️
Py-3.11.9 97.04% <100.00%> (+0.01%) ⬆️
Py-3.12.10 97.90% <100.00%> (+0.01%) ⬆️
Py-3.13.3 97.89% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.76% <100.00%> (+0.02%) ⬆️
Py-3.9.22 97.26% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 86.68% <100.00%> (+0.10%) ⬆️
VM-macos 97.09% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.88% <100.00%> (+<0.01%) ⬆️
VM-windows 95.50% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 1, 2025

CodSpeed Performance Report

Merging #11109 will not alter performance

Comparing patchback/backports/3.13/cfb99316e1fd89943b1f6c3793d286629b7acc3d/pr-11106 (146b917) with 3.13 (b2242d6)

Summary

✅ 59 untouched benchmarks

@bdraco bdraco changed the title Fix cookies with duplicate names being lost when updating cookie jar (#11106) [PR #11106/cfb9931 backport][3.13] Fix cookies with duplicate names being lost when updating cookie jar Jun 1, 2025
@bdraco bdraco marked this pull request as ready for review June 1, 2025 14:42
@bdraco bdraco requested review from webknjaz and asvetlov as code owners June 1, 2025 14:42
@bdraco bdraco merged commit 1f02d7d into 3.13 Jun 1, 2025
35 checks passed
@bdraco bdraco deleted the patchback/backports/3.13/cfb99316e1fd89943b1f6c3793d286629b7acc3d/pr-11106 branch June 1, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant