Skip to content

[PR #11107/21d640d backport][3.12] Avoid creating closed futures that will never be awaited #11110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 1, 2025

(cherry picked from commit 21d640d)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 1, 2025
@bdraco bdraco changed the title Avoid creating closed futures that will never be awaited (#11107) [PR #11107/21d640d backport][3.12] Avoid creating closed futures that will never be awaited Jun 1, 2025
Copy link

codspeed-hq bot commented Jun 1, 2025

CodSpeed Performance Report

Merging #11110 will not alter performance

Comparing patchback/backports/3.12/21d640dc4b046be18bcb42aad8fa5445198fd219/pr-11107 (07dfd46) with 3.12 (b1aa238)

Summary

✅ 59 untouched benchmarks

Copy link

codecov bot commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (b1aa238) to head (07dfd46).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #11110   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         130      130           
  Lines       41999    42035   +36     
  Branches     2301     2305    +4     
=======================================
+ Hits        41267    41303   +36     
  Misses        557      557           
  Partials      175      175           
Flag Coverage Δ
CI-GHA 98.14% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.88% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.50% <100.00%> (-0.01%) ⬇️
OS-macOS 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.86% <100.00%> (-0.01%) ⬇️
Py-3.10.17 97.37% <100.00%> (+<0.01%) ⬆️
Py-3.11.12 97.55% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.04% <100.00%> (-0.01%) ⬇️
Py-3.12.10 97.91% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 97.89% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.76% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.27% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 82.63% <100.00%> (-8.26%) ⬇️
VM-macos 97.09% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.88% <100.00%> (+<0.01%) ⬆️
VM-windows 95.50% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review June 1, 2025 17:05
@bdraco bdraco requested review from webknjaz and asvetlov as code owners June 1, 2025 17:05
@bdraco bdraco merged commit 06887a9 into 3.12 Jun 1, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/21d640dc4b046be18bcb42aad8fa5445198fd219/pr-11107 branch June 1, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant