Skip to content

Fix cookie parsing issues #11112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 112 commits into from
Jun 2, 2025
Merged
Changes from 1 commit
Commits
Show all changes
112 commits
Select commit Hold shift + click to select a range
57dfafb
cookie parser
bdraco Jun 1, 2025
13bed23
cookie parser
bdraco Jun 1, 2025
a0918d8
tweaks
bdraco Jun 1, 2025
53cafe0
tweaks
bdraco Jun 1, 2025
86f3da1
tweaks
bdraco Jun 1, 2025
ee37df4
fixes
bdraco Jun 1, 2025
0f92c56
cleanup
bdraco Jun 1, 2025
b448ca8
cleanup
bdraco Jun 1, 2025
eb9e0cb
simpler
bdraco Jun 1, 2025
e3444bb
simpler
bdraco Jun 1, 2025
aaacbcc
simpler
bdraco Jun 1, 2025
d39dee5
simpler
bdraco Jun 1, 2025
96c1a96
simpler
bdraco Jun 1, 2025
88fae3e
simpler
bdraco Jun 1, 2025
e1648ca
simpler
bdraco Jun 1, 2025
8c09fe8
simpler
bdraco Jun 1, 2025
8c6736e
simpler
bdraco Jun 1, 2025
3d6ed97
simpler
bdraco Jun 1, 2025
b14f6c9
simpler
bdraco Jun 1, 2025
61fcdd6
simpler
bdraco Jun 1, 2025
36a19e0
simpler
bdraco Jun 1, 2025
38ff925
simpler
bdraco Jun 1, 2025
4514d1e
simpler
bdraco Jun 1, 2025
809679a
simpler
bdraco Jun 1, 2025
1dec309
simpler
bdraco Jun 1, 2025
908a4a7
simpler
bdraco Jun 1, 2025
3f29be2
simpler
bdraco Jun 1, 2025
b600fec
simpler
bdraco Jun 1, 2025
304ef1d
simpler
bdraco Jun 1, 2025
a665421
vendor it
bdraco Jun 1, 2025
e74f2c5
vendor it
bdraco Jun 1, 2025
dd4b2f6
vendor it
bdraco Jun 1, 2025
4c92a7a
vendor it
bdraco Jun 1, 2025
9eb3bbf
vendor it
bdraco Jun 1, 2025
21f478c
vendor it
bdraco Jun 1, 2025
d0f4e13
preen
bdraco Jun 1, 2025
87f3ecd
preen
bdraco Jun 1, 2025
3a0e77f
preen
bdraco Jun 1, 2025
3477c01
preen
bdraco Jun 1, 2025
9c5638d
preen
bdraco Jun 1, 2025
b430a85
fixes
bdraco Jun 1, 2025
00c4f68
cleanup
bdraco Jun 1, 2025
aa2fc47
combine
bdraco Jun 1, 2025
d3d990d
tweaks
bdraco Jun 1, 2025
38a35f5
reduce
bdraco Jun 1, 2025
992f4c3
cover
bdraco Jun 1, 2025
de6293c
clean
bdraco Jun 1, 2025
62995f8
clean
bdraco Jun 1, 2025
3fdf0cc
preen
bdraco Jun 1, 2025
922494a
preen
bdraco Jun 1, 2025
84e9d87
fix both sides
bdraco Jun 1, 2025
ba32386
cover
bdraco Jun 1, 2025
346570c
cover
bdraco Jun 1, 2025
0b5eb3d
mypy
bdraco Jun 1, 2025
101eaf3
mypy
bdraco Jun 1, 2025
479e3d5
mypy
bdraco Jun 1, 2025
d0bb035
mypy
bdraco Jun 1, 2025
0dff6d5
changelog
bdraco Jun 1, 2025
1a6a6ec
add coverage for dollar
bdraco Jun 1, 2025
0eee175
make sure to handle case insen
bdraco Jun 1, 2025
8bc198e
cleanups
bdraco Jun 1, 2025
d6957aa
reduce
bdraco Jun 1, 2025
a1229ef
fix test
bdraco Jun 1, 2025
5150a57
split it
bdraco Jun 1, 2025
1757b37
make it pass
bdraco Jun 1, 2025
266de20
Revert "make it pass"
bdraco Jun 1, 2025
5af5c0b
Revert "split it"
bdraco Jun 1, 2025
d457096
preen
bdraco Jun 1, 2025
b310cf9
document
bdraco Jun 1, 2025
00f12ca
cover the remaining lines
bdraco Jun 1, 2025
0f5447f
refactor tests
bdraco Jun 1, 2025
6ca1617
cleanup
bdraco Jun 1, 2025
9719a9b
use it in all places
bdraco Jun 1, 2025
12a950a
preen
bdraco Jun 1, 2025
5a7cb94
preen
bdraco Jun 1, 2025
54047eb
fix
bdraco Jun 1, 2025
4ff3982
type
bdraco Jun 1, 2025
85da85c
type
bdraco Jun 1, 2025
759e3e4
Merge branch 'master' into cookie_fix
bdraco Jun 1, 2025
2021828
tests for shared cookie
bdraco Jun 1, 2025
1061413
fix
bdraco Jun 1, 2025
b47e93b
__all__
bdraco Jun 1, 2025
9855794
relo
bdraco Jun 1, 2025
0761fb3
relo
bdraco Jun 1, 2025
c789580
relo
bdraco Jun 1, 2025
e82881d
relo
bdraco Jun 2, 2025
361897f
relo
bdraco Jun 2, 2025
ee932e9
revert test change
bdraco Jun 2, 2025
edff948
restore tests
bdraco Jun 2, 2025
0777719
migrate
bdraco Jun 2, 2025
743e0d5
migrate
bdraco Jun 2, 2025
49912cc
preen
bdraco Jun 2, 2025
b7c7422
Update tests/test_client_session.py
bdraco Jun 2, 2025
08bd536
lint
bdraco Jun 2, 2025
1f3ece8
one more fix
bdraco Jun 2, 2025
ed95a15
missed one
bdraco Jun 2, 2025
61bc5a3
missed one
bdraco Jun 2, 2025
c27d813
more fixes
bdraco Jun 2, 2025
6a14098
preen
bdraco Jun 2, 2025
c7fc002
avoid patching
bdraco Jun 2, 2025
4030ec8
preen
bdraco Jun 2, 2025
f8e501d
fix perf regression
bdraco Jun 2, 2025
675c1f3
use pickle api as it should be more stable than setting protected met…
bdraco Jun 2, 2025
049c149
comments
bdraco Jun 2, 2025
7efa55c
simplify
bdraco Jun 2, 2025
34216a8
cover
bdraco Jun 2, 2025
1317e8c
remove dupes
bdraco Jun 2, 2025
b39445e
remove dupes
bdraco Jun 2, 2025
29ce89b
remove dupes
bdraco Jun 2, 2025
745fca1
fix issue #4327
bdraco Jun 2, 2025
0acf73c
fix #4493
bdraco Jun 2, 2025
6e80350
preen
bdraco Jun 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simpler
  • Loading branch information
bdraco committed Jun 1, 2025
commit 8c6736e15396d7b7ad03175d143236ad5d4b225a
2 changes: 1 addition & 1 deletion aiohttp/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ def _set_and_validate_morsel_values(


def create_cookie_morsel(
name: str, value: str, *, coded_value: Optional[str] = None
name: str, value: str, coded_value: Optional[str] = None
) -> Morsel[str]:
"""
Create a Morsel with pre-validated name, bypassing validation.
Expand Down