feat: support warnings in the generated advanced config pages #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying aiven-docs with
|
| Latest commit: |
f3998d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ca550af.aiven-docs.pages.dev |
| Branch Preview URL: | https://add-support-for-restart-warn.aiven-docs.pages.dev |
github-actions
bot
added
the
tech
jadkik
force-pushed
the
add-support-for-restart-warnings
branch
3 times, most recently
from
1e8ccf1 to
e5f8961
Compare
jadkik
force-pushed
the
add-support-for-restart-warnings
branch
from
e5f8961 to
08c2bd4
Compare
jadkik
force-pushed
the
add-support-for-restart-warnings
branch
from
08c2bd4 to
f3998d9
Compare
|
@jadkik , thank you! Let's have another pair of eyes on this one, from the team :-) |
wojcik-dorota
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
With a new flag added to the API we can generate a better-looking warning rather than relying on the plain text in the description.
Results
With the custom CSS `.property-warning`:
The changes for this alternative are no longer in the PR
With the standard CSS `.brand .brand--warning`:
It would look different from the badges in our own code, e.g. here:
I couldn't figure out how to reuse the code from our own component in the generated code:
https://github.com/aiven/aiven-docs/blob/d10e2dc0bfcc88f82a2d24a5aee55be1bfbbe1da/src/components/Badges/LimitedBadge/index.tsx
Checklist
/docs/.