refactor: use upstream UnifiedLog analyzeAndValidateRecords [INK-127] #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharris1727
reviewed
Mar 14, 2025
| @@ -1441,7 +1446,7 @@ private LogAppendInfo analyzeAndValidateRecords(MemoryRecords records, | |||
| } | |||
| // we only validate V2 and higher to avoid potential compatibility issues with older clients | |||
| if (batch.magic() >= RecordBatch.MAGIC_VALUE_V2 && origin == AppendOrigin.CLIENT && batch.baseOffset() != 0) { | |||
| throw new InvalidRecordException("The baseOffset of the record batch in the append to " + topicPartition() + " should " + | |||
| throw new InvalidRecordException("The baseOffset of the record batch in the append to " + topicPartition + " should " + | |||
There was a problem hiding this comment.
nit: do you think we can make a tiny upstream change to add TopicPartition topicPartition = this.topicPartition(); or something similar, so that only the method signatures conflict?
There was a problem hiding this comment.
What about something like: 13d2055
I wonder how to "sell" it. I guess we could say that as topicPartition is stable for a unified log, there is no need to depend on localLog reference.
There was a problem hiding this comment.
@gharris1727 I opened apache/kafka#19253 as draft. Lmk if looks good, and can open it for review
jeqo
force-pushed
the
jeqo/INK-127-adopt-upstream
branch
from
54804c0 to
6e35dc9
Compare
Now that analyzeAndValidateRecords is available on UnifiedLog.java make use of it by tweaking the access to the method.
jeqo
force-pushed
the
jeqo/INK-127-adopt-upstream
branch
from
6e35dc9 to
198e17d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that analyzeAndValidateRecords is available on UnifiedLog.java make use of it by tweaking the access to the method.