refactor(inkless): pass bytebuffer around #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
jeqo/fixed-thread-pools
to
jeqo/refactor-append-completer
May 22, 2025 08:53
|
@jeqo this seems to need rebasing |
This arguably does not reduce allocation as a buffer still needs to be created to be uploaded and a subset is allocated to be cached; but passing the bytebuffer may allow some further improvements as have resumable inputstreams for remote storage uploads.
jeqo
force-pushed
the
jeqo/less-allocation
branch
from
ce4b6f0 to
2048356
Compare
jeqo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arguably does not reduce allocation as a buffer still needs to be created to be uploaded and a subset is allocated to be cached; but passing the bytebuffer may allow some further improvements as have resumable inputstreams for remote storage uploads.
This removes the need to allocate the bytes. It passes byteBuffer to uploader, so a ByteBufferInputStream can be used to upload; and passes a byteBuffer to the cache, so a slice array can be passed to the cache.