Add AWS STS runtime dependency #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I saw that you do not plan to accept patches for this project. If you think, this PR is out of scope, feel free to close it again.
First, I would like to thank the authors of this project for proposing KIP-1150 and giving a first look into the implementation. It looks really interesting!
When accessing Amazon S3 from within Kubernetes, it is common to use IAM roles for service accounts (IRSA). According to the Amazon EKS > IAM roles for service accounts docs, this requires the sts module on the classpath:
This PR adds
software.amazon.awssdk:stsas a runtime dependency in the same version as the S3 SDK dependency.In addition, it also fixes a minor typo:
awsskd->awssdk.