Skip to content

wip(server-signing): do not merge this #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Feb 27, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the account-kit by adding new dependencies, updating existing middleware documentation, and implementing a new AlchemyServerSignerClient class with methods for account creation and authentication.

Detailed summary

  • Added dependencies: @turnkey/api-key-stamper and @turnkey/crypto.
  • Updated documentation for alchemyGasManagerMiddleware, simplifying the policyId type.
  • Introduced AlchemyServerSignerClient with methods for email authentication, account creation, and OAuth handling.
  • Refactored completeAuthWithBundle and submitOtpCode methods for better error handling and functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:32pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:32pm

Copy link
Collaborator Author


How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@moldy530 moldy530 force-pushed the moldy/02-26-wip_server-signing_do_not_merge_this branch from dc0673d to 02080d2 Compare February 27, 2025 16:17
if (user) {
// OTPId is returned when using otp auth, you will need it to complete OTP auth
// @ts-expect-error ignore this await issue it's an example
const { orgId, otpId } = await example.initEmailAuth({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'orgId' is assigned a value but never used.

if (user) {
// OTPId is returned when using otp auth, you will need it to complete OTP auth
// @ts-expect-error ignore this await issue it's an example
const { orgId, otpId } = await example.initEmailAuth({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'otpId' is assigned a value but never used.

});
} else {
// @ts-expect-error ignore this await issue it's an example
const { orgId, otpId } = await example.createAccount({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'orgId' is assigned a value but never used.

});
} else {
// @ts-expect-error ignore this await issue it's an example
const { orgId, otpId } = await example.createAccount({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'otpId' is assigned a value but never used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant