-
Notifications
You must be signed in to change notification settings - Fork 170
wip(server-signing): do not merge this #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
dc0673d
to
02080d2
Compare
if (user) { | ||
// OTPId is returned when using otp auth, you will need it to complete OTP auth | ||
// @ts-expect-error ignore this await issue it's an example | ||
const { orgId, otpId } = await example.initEmailAuth({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'orgId' is assigned a value but never used.
if (user) { | ||
// OTPId is returned when using otp auth, you will need it to complete OTP auth | ||
// @ts-expect-error ignore this await issue it's an example | ||
const { orgId, otpId } = await example.initEmailAuth({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'otpId' is assigned a value but never used.
}); | ||
} else { | ||
// @ts-expect-error ignore this await issue it's an example | ||
const { orgId, otpId } = await example.createAccount({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'orgId' is assigned a value but never used.
}); | ||
} else { | ||
// @ts-expect-error ignore this await issue it's an example | ||
const { orgId, otpId } = await example.createAccount({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'otpId' is assigned a value but never used.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the
account-kit
by adding new dependencies, updating existing middleware documentation, and implementing a newAlchemyServerSignerClient
class with methods for account creation and authentication.Detailed summary
@turnkey/api-key-stamper
and@turnkey/crypto
.alchemyGasManagerMiddleware
, simplifying thepolicyId
type.AlchemyServerSignerClient
with methods for email authentication, account creation, and OAuth handling.completeAuthWithBundle
andsubmitOtpCode
methods for better error handling and functionality.