feat: adds webauthn client tests #1563

linnall · 2025-04-24T22:18:48Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR introduces support for a new webauthn mode in the Modular Account V2 functionality, allowing accounts to be created and managed without a signer. It includes a new gas estimator and updates various types and functions to accommodate this change.

Detailed summary

Updated CreateModularAccountV2Params to include CreateModularAccountV2ParamsNoSigner.
Modified return types in createModularAccountV2 to support ModularAccountV2NoSigner.
Added webauthnGasEstimator function for estimating gas usage.
Created documentation for webauthnGasEstimator.
Enhanced createModularAccountV2Client to handle webauthn mode.
Introduced ModularAccountV2NoSigner type for accounts without a signer.
Updated various functions to handle parameters specific to webauthn.
Added tests for signing and validating messages with WebAuthn accounts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-04-24T22:18:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2025 3:35pm
aa-sdk-ui-demo	❌ Failed (Inspect)			May 22, 2025 3:35pm

graphite-app · 2025-04-24T22:18:54Z

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2025-04-24T22:19:16Z

🌿 Documentation Preview

Name	Status	Preview	Updated (UTC)
Alchemy Docs	✅ Ready	🔗 Visit Preview	May 22, 2025, 3:31 PM

linnall · 2025-04-24T22:19:53Z

account-kit/smart-contracts/src/ma-v2/client/client.test.ts

+    // connect session key
+    let sessionKeyClient = await createModularAccountV2Client({
+      chain: instance.chain,
+      signer: webAuthnSigningMethodsSessionKey,


should be passing in instance of SmartAccountSigner here

linnall · 2025-04-24T22:22:15Z

account-kit/smart-contracts/src/ma-v2/client/client.test.ts

+    name: "backUp",
+  });
+
+  const webAuthnSigningMethods: SmartAccountSigner = new WebAuthnSigningMethods(


I think I am mistakenly treating this like an instance of SmartAccountSigner when this is a standalone collection of webauthn signing methods, so it would get access to the WebAuthnCredentials via the account

I left comments in the spec about this. It's not a smart account signer, it's what's used to create the various sign* methods on the account itself. the account doesn't take a signer as input anymore, and just takes in the credential

…al on try-webauthn.appspot.com

…k together

gpuliyar · 2025-05-22T15:33:41Z

account-kit/smart-contracts/src/ma-v2/client/client.test.ts

@@ -94,6 +102,152 @@ describe("MA v2 Tests", async () => {
    accounts.unfundedAccountOwner,
  );

+  const publicKey = {


⚠️ [eslint] <@typescript-eslint/no-unused-vars> _{reported by reviewdog 🐶}
'publicKey' is assigned a value but never used.

moldy530 · 2025-05-22T15:31:48Z

aa-sdk/core/src/middleware/defaults/webauthnGasEstimator.ts

+ * ```
+ *
+ * @param {ClientMiddlewareFn} [gasEstimator] Optional custom gas estimator function
+ * @returns {Function} A function that takes user operation struct and parameters, estimates gas usage, and returns the user operation with gas limits.


nit:

Suggested change

* @returns {Function} A function that takes user operation struct and parameters, estimates gas usage, and returns the user operation with gas limits.

* @returns {ClientMiddlewareFn} A function that takes user operation struct and parameters, estimates gas usage, and returns the user operation with gas limits.

moldy530 · 2025-05-22T15:32:17Z

aa-sdk/core/src/middleware/defaults/webauthnGasEstimator.ts

+    console.log({ chainHas7212 });
+
+    console.log("...");
+    console.log(BigInt(typeof pvg === "string" ? BigInt(pvg) : pvg));
+    console.log(chainHas7212 ? 10000n : 300000n);
+    console.log(
+      BigInt(typeof pvg === "string" ? BigInt(pvg) : pvg) +
+        (chainHas7212 ? 10000n : 300000n)
+    );


Suggested change

console.log({ chainHas7212 });

console.log("...");

console.log(BigInt(typeof pvg === "string" ? BigInt(pvg) : pvg));

console.log(chainHas7212 ? 10000n : 300000n);

console.log(

BigInt(typeof pvg === "string" ? BigInt(pvg) : pvg) +

(chainHas7212 ? 10000n : 300000n)

);

moldy530 · 2025-05-22T16:43:23Z

account-kit/smart-contracts/src/ma-v2/account/common/modularAccountV2Base.ts

@@ -70,9 +73,24 @@ export type ModularAccountV2<
  encodeCallData: (callData: Hex) => Promise<Hex>;
 };

+export type ModularAccountV2NoSigner = SmartContractAccount<


Suggested change

export type ModularAccountV2NoSigner = SmartContractAccount<

export type WebauthnModularAccountV2 = SmartContractAccount<

moldy530 · 2025-05-22T16:44:27Z

account-kit/smart-contracts/src/ma-v2/account/modularAccountV2.ts

@@ -54,13 +57,36 @@ export type CreateModularAccountV2Params<
      }
  );

+// currently the only ModularAccountV2 mode that doesn't require a signer is "webauthn"


can we just call it webauthn mav2?

moldy530 · 2025-05-22T16:44:46Z

account-kit/smart-contracts/src/ma-v2/account/modularAccountV2.ts

+  "transport" | "chain" | "accountAddress"
+> & {
+  mode: "webauthn";
+  params: ToWebAuthnAccountParameters;


what are these types? can we flatten them rather than having params here?

moldy530 · 2025-05-22T16:51:34Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

@@ -41,6 +52,15 @@ export type CreateModularAccountV2ClientParams<
    "transport" | "account" | "chain"
  >;

+export type CreateModularAccountV2ClientParamsNoSigner<


moldy530 · 2025-05-22T16:51:49Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

@@ -50,7 +70,7 @@ export type CreateModularAccountV2AlchemyClientParams<
  "transport"
 > &
  Omit<
-    AlchemySmartAccountClientConfig<TChain, LightAccount<TSigner>>,
+    AlchemySmartAccountClientConfig<TChain, LightAccount<TSigner>>, // TO DO: split this type so that it doesn't require a signer


why is this LightAccount?

moldy530 · 2025-05-22T16:52:33Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

+  args: CreateModularAccountV2ClientParamsNoSigner<TTransport, TChain> &
+    NotType<TTransport, AlchemyTransport> & {
+      params: ToWebAuthnAccountParameters;
+    }


why does this need the params: intersection? shouldn't that be part of CreateModularAccountV2ClientParamsNoSigner?

moldy530 · 2025-05-22T16:52:45Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

+    );
+  }
+
+  console.log("\n\n\n\n\n a \n\n\n\n\n");


Suggested change

console.log("\n\n\n\n\n a \n\n\n\n\n");

moldy530 · 2025-05-22T16:53:04Z

account-kit/smart-contracts/src/ma-v2/modules/webauthn-validation/signer.ts

ni can we call this signingMethods.ts?

or functions, w/e we export from the file

github-actions bot temporarily deployed to docs-preview April 24, 2025 22:19 Inactive

linnall commented Apr 24, 2025

View reviewed changes

vercel bot deployed to Preview – aa-sdk-ui-demo April 24, 2025 22:21 View deployment

linnall commented Apr 24, 2025

View reviewed changes

vercel bot deployed to Preview – aa-sdk-site April 24, 2025 22:23 View deployment

github-actions bot temporarily deployed to docs-preview April 29, 2025 19:10 Inactive

vercel bot deployed to Preview – aa-sdk-ui-demo April 29, 2025 19:12 View deployment

vercel bot deployed to Preview – aa-sdk-site April 29, 2025 19:14 View deployment

github-actions bot temporarily deployed to docs-preview April 29, 2025 21:24 Inactive

vercel bot deployed to Preview – aa-sdk-ui-demo April 29, 2025 21:25 View deployment

vercel bot deployed to Preview – aa-sdk-site April 29, 2025 21:28 View deployment

vercel bot deployed to Preview – aa-sdk-ui-demo April 30, 2025 20:13 View deployment

vercel bot deployed to Preview – aa-sdk-site April 30, 2025 20:23 View deployment

vercel bot deployed to Preview – aa-sdk-ui-demo April 30, 2025 20:25 View deployment

vercel bot deployed to Preview – aa-sdk-site April 30, 2025 20:40 View deployment

github-actions bot had a problem deploying to docs-preview May 9, 2025 21:43 Failure

vercel bot deployed to Preview May 9, 2025 21:52 View deployment

github-actions bot temporarily deployed to docs-preview May 11, 2025 02:41 Inactive

vercel bot had a problem deploying to Preview May 11, 2025 02:43 Failure

vercel bot had a problem deploying to Preview May 12, 2025 19:57 Failure

github-actions bot temporarily deployed to docs-preview May 12, 2025 20:11 Inactive

vercel bot had a problem deploying to Preview May 12, 2025 20:19 Failure

linnall force-pushed the linna/webauth-tests branch from 36cd477 to 7549458 Compare May 12, 2025 20:21

github-actions bot temporarily deployed to docs-preview May 12, 2025 20:21 Inactive

github-actions bot temporarily deployed to docs-preview May 12, 2025 20:28 Inactive

vercel bot had a problem deploying to Preview May 12, 2025 20:37 Failure

github-actions bot temporarily deployed to docs-preview May 13, 2025 00:03 Inactive

linnall added 3 commits May 22, 2025 08:18

chore: adds credential and mock response from self generated credenti…

3578196

…al on try-webauthn.appspot.com

fix: rename webAuthnCredentials to webAuthnAccountParams

0baeaff

chore: adds to do

87f49a1

vercel bot deployed to Preview May 22, 2025 15:20 View deployment

linnall and others added 21 commits May 22, 2025 08:27

feat: add ability to create a webauthn ModularAccountV2 without a signer

129db19

chore: removes unused code

c423339

fix: ensures presence of signer is explicit

04068c1

fix: refactor to not destructure

c805e05

feat: adds account functions for webauthn

b8f32ef

feat: add webauthn gas estimator

2dfea8c

chore: fix lint, change to use type narrowing instead

7ae0280

feat: add webauthn signer

f4f03d0

chore: update dummy sig

a299c85

feat: modifies mav2 smart account client and mav2 client tests to wor…

0042f41

…k together

fix: add documenting comment for webauthn gas estimator usage

b2a18d9

fix: adds documentation comment for webauthnGasEstimator usage

fe9ea56

chore: wip deploy webauthn account then sign message

0657350

fix: prepend signatures with 0xff

c258702

fix: prepend signature regardless of deferred actions data presence

c5bec9c

chore: wip debugging

ab0dbc4

fix: debug

8255eb3

chore: adds updated mock authenticator response

7eb3c4c

fix: prefixes signature with offset

9f8d3a8

chore: update credentials and mocked authenticator response

f2d0df9

chore: updates credentials and authenticator response

aec0234

linnall force-pushed the linna/webauth-tests branch from 3f608b1 to aec0234 Compare May 22, 2025 15:29

github-actions bot temporarily deployed to docs-preview May 22, 2025 15:29 Inactive

gpuliyar reviewed May 22, 2025

View reviewed changes

vercel bot had a problem deploying to Preview May 22, 2025 15:35 Failure

moldy530 reviewed May 22, 2025

View reviewed changes

	* @returns {Function} A function that takes user operation struct and parameters, estimates gas usage, and returns the user operation with gas limits.
	* @returns {ClientMiddlewareFn} A function that takes user operation struct and parameters, estimates gas usage, and returns the user operation with gas limits.

	export type ModularAccountV2NoSigner = SmartContractAccount<
	export type WebauthnModularAccountV2 = SmartContractAccount<

feat: adds webauthn client tests #1563

Are you sure you want to change the base?

feat: adds webauthn client tests #1563

Uh oh!

Conversation

linnall commented Apr 24, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Apr 24, 2025

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌿 Documentation Preview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linnall commented Apr 24, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Apr 24, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading