Skip to content

feat: add webauthn signer #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Apr 28, 2025

PR-Codex overview

This PR introduces the webauthnSigningFunctions in the signer.ts file, which provides methods for generating signatures for user operations, messages, and typed data using WebAuthn. It enhances the signing capabilities for smart accounts with added utility functions.

Detailed summary

  • Added webauthnSigningFunctions to create a signing object.
  • Implemented methods for:
    • Generating a dummy signature.
    • Signing user operation hashes.
    • Signing messages.
    • Signing typed data.
  • Utilized WebAuthnP256 for signing operations.
  • Integrated hashMessage, hashTypedData, and pack1271Signature for signature processing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 7:32pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 7:32pm

Copy link

graphite-app bot commented Apr 28, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@howydev howydev marked this pull request as draft April 28, 2025 22:12
Copy link

github-actions bot commented Apr 28, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Apr 29, 2025, 7:28 PM


* ```ts
* import { webauthnSigningFunctions } from "@account-kit/smart-contracts";
* import { LocalAccountSigner } from "@aa-sdk/core";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant