feat: adds test for webauthn gas estimator #1576
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7 tasks
gpuliyar
reviewed
Apr 30, 2025
| @@ -71,6 +71,7 @@ | |||
| import { generatePrivateKey, privateKeyToAccount } from "viem/accounts"; | |||
| import { mintableERC20Abi, mintableERC20Bytecode } from "../utils.js"; | |||
| import { type P256Credential } from "viem/account-abstraction"; | |||
| import { webauthnGasEstimator } from "@aa-sdk/core"; | |||
There was a problem hiding this comment.
'webauthnGasEstimator' is defined but never used.
linnall
force-pushed
the
linna/webauthn-gas-estimator-tests
branch
from
9ad981e to
2900b34
Compare
linnall
force-pushed
the
linna/webauth-tests
branch
from
36cd477 to
7549458
Compare
linnall
force-pushed
the
linna/webauth-tests
branch
from
3f608b1 to
aec0234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces a new test for estimating gas when sending User Operations (UOs) using a
webauthnaccount, incorporating a 2000 gas buffer. It utilizes thewebauthnGasEstimatorfrom the@aa-sdk/corepackage to modify gas estimates.Detailed summary
webauthnGasEstimatorfrom@aa-sdk/core.webauthnaccount.