Skip to content

feat: adds webauthn account #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: adds webauthn account #1597

wants to merge 7 commits into from

Conversation

linnall
Copy link
Collaborator

@linnall linnall commented May 6, 2025

Pull Request Checklist


PR-Codex overview

This PR introduces support for a new account type, ModularAccountV2NoSigner, which allows operations without a signer, specifically for the webauthn mode. It modifies the createMAv2Base and createModularAccountV2 functions to accommodate these changes.

Detailed summary

  • Added ModularAccountV2NoSigner type for accounts without a signer.
  • Updated createMAv2Base to handle configurations with and without a signer.
  • Introduced CreateModularAccountV2ParamsNoSigner type for webauthn mode.
  • Enhanced createModularAccountV2 to accept both signer and no-signer configurations.
  • Implemented logic for handling webauthn parameters and account initialization.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ❌ Failed (Inspect) May 8, 2025 6:39pm
aa-sdk-ui-demo ❌ Failed (Inspect) May 8, 2025 6:39pm

Copy link

github-actions bot commented May 6, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview May 8, 2025, 6:33 PM

@github-actions github-actions bot temporarily deployed to docs-preview May 6, 2025 18:13 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview May 6, 2025 18:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants