-
Notifications
You must be signed in to change notification settings - Fork 167
feat: adds webauthn account #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
linnall
wants to merge
7
commits into
main
Choose a base branch
from
linna/webauthn-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🌿 Documentation Preview
|
linnall
commented
May 6, 2025
Blu-J
reviewed
May 6, 2025
account-kit/smart-contracts/src/ma-v2/account/common/modularAccountV2Base.ts
Outdated
Show resolved
Hide resolved
Blu-J
reviewed
May 6, 2025
account-kit/smart-contracts/src/ma-v2/account/common/modularAccountV2Base.ts
Outdated
Show resolved
Hide resolved
Blu-J
reviewed
May 6, 2025
account-kit/smart-contracts/src/ma-v2/account/modularAccountV2.ts
Outdated
Show resolved
Hide resolved
Blu-J
reviewed
May 6, 2025
account-kit/smart-contracts/src/ma-v2/account/modularAccountV2.ts
Outdated
Show resolved
Hide resolved
Blu-J
reviewed
May 6, 2025
account-kit/smart-contracts/src/ma-v2/account/modularAccountV2.ts
Outdated
Show resolved
Hide resolved
Blu-J
reviewed
May 6, 2025
account-kit/smart-contracts/src/ma-v2/account/modularAccountV2.ts
Outdated
Show resolved
Hide resolved
Blu-J
reviewed
May 6, 2025
account-kit/smart-contracts/src/ma-v2/account/modularAccountV2.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR introduces support for a new account type,
ModularAccountV2NoSigner
, which allows operations without a signer, specifically for thewebauthn
mode. It modifies thecreateMAv2Base
andcreateModularAccountV2
functions to accommodate these changes.Detailed summary
ModularAccountV2NoSigner
type for accounts without a signer.createMAv2Base
to handle configurations with and without a signer.CreateModularAccountV2ParamsNoSigner
type forwebauthn
mode.createModularAccountV2
to accept both signer and no-signer configurations.webauthn
parameters and account initialization.