feat: add passkey support to rn-signer #1598
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
🌿 Documentation Preview
|
moldy530
force-pushed
the
moldy/pk-rn-signer
branch
from
0006551 to
56eb271
Compare
moldy530
force-pushed
the
moldy/pk-rn-signer
branch
from
56eb271 to
cd4979a
Compare
| this.webauthnStamper = new PasskeyStamper({ | ||
| rpId: rp?.id ?? "localhost", | ||
| }); | ||
| this.rpId = rp?.id ?? "localhost"; | ||
| this.rpName = rp?.name ?? "localhost"; |
There was a problem hiding this comment.
if we don't get the rp config I think we actually need to not setup the stamper, and then below we need to throw if there's no config for the stamper
|
Still needs to be tested, but to set it up a dev has to do this: https://github.com/f-23/react-native-passkey?tab=readme-ov-file#configuration |
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces the
react-native-passkeylibrary to enhance account creation and authentication processes in theRNSignerClientclass, integrating passkey functionality and updating dependencies accordingly.Detailed summary
react-native-passkeydependency inpackage.json.@turnkey/react-native-passkey-stamperdependency.RNSignerClientto handle passkey authentication.createPasskeyandPasskeyStamperfor passkey management.generateRandomBufferutility for challenge generation.