fix: build permit even maxTokenAmount is set to 0 #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysim3d
requested review from
moldy530,
rthomare,
dancoombs,
dphilipson,
linnall,
adamegyed,
howydev,
Zer0dot,
jaypaik,
Blu-J,
jakehobbs,
avarobinson,
florrdv and
blakecduncan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🌿 Documentation Preview
|
dphilipson
approved these changes
May 8, 2025
niveda-krish
approved these changes
May 9, 2025
Blu-J
reviewed
May 12, 2025
| @@ -408,7 +408,7 @@ const generateSignedPermit = async < | |||
|
|
|||
| let maxAmountToken = maxUint256; | |||
|
|
|||
| if (policyToken.maxTokenAmount) { | |||
| if (policyToken.maxTokenAmount !== undefined) { | |||
There was a problem hiding this comment.
❔ What about the case that maxTokenAmount == null
There was a problem hiding this comment.
new bee to TS: this is typed as 'undefined | bigInt', is that possible to assign 'null' to it?
There was a problem hiding this comment.
i think best practice is to check for policyToken.maxTokenAmount != null, which checks for null or undefined.
i believe the main reason to make the change here is to defend against someone possibly making a change later where it's nullable and doesn't notice that you are strictly checking for undefined here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on refining the condition that checks if
maxTokenAmountis defined for apolicyToken. The change enhances code clarity by explicitly checking forundefinedrather than relying on a truthy check.Detailed summary
if (policyToken.maxTokenAmount)toif (policyToken.maxTokenAmount !== undefined)ingasManager.ts.