Feature/morf 72 extra audit fields #275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonknight73
commented
Jul 11, 2023
| @@ -184,7 +184,7 @@ public SqlDialect(String schemaName) { | |||
| * @return The statements required to deploy the table and its indexes. | |||
| */ | |||
| public Collection<String> tableDeploymentStatements(Table table) { | |||
| Builder<String> statements = ImmutableList.<String>builder(); | |||
There was a problem hiding this comment.
Remove unnecessary type
jonknight73
commented
Jul 11, 2023
| view.getName() + | ||
| " AS (" + | ||
| convertStatementToSQL(view.getSelectStatement()) + | ||
| ")"; |
There was a problem hiding this comment.
Remove unnecessary StringBuilder.
jonknight73
commented
Jul 11, 2023
| result.append(" ").append(defaultNullOrder()); | ||
|
|
||
| return result.toString().trim(); | ||
| return (getSqlFrom(currentOrderByField) + " " + defaultNullOrder()).trim(); |
There was a problem hiding this comment.
Remove unnecessary StringBuilder.
jonknight73
commented
Jul 11, 2023
| @@ -1325,7 +1321,7 @@ protected void appendJoin(StringBuilder result, Join join, String innerJoinKeywo | |||
| } else { | |||
| // MySql supports no ON criteria and ON TRUE, but the other platforms | |||
| // don't, so just keep things simple. | |||
| result.append(String.format(" ON 1=1")); | |||
| result.append(" ON 1=1"); | |||
There was a problem hiding this comment.
Remove redundant String.format
jonknight73
commented
Jul 11, 2023
| @@ -2417,13 +2425,29 @@ protected String getLeastFunctionName() { | |||
| /** | |||
| * Produce SQL for getting the row number of the row in the partition | |||
| * | |||
| * @return a string representation of the SQL for finding the last day of the month. | |||
| * @return a string representation of the SQL for getting the row number of the row in the partition. | |||
There was a problem hiding this comment.
Previous change had cut and pasted the wrong JavaDocs without updating it.
jonknight73
commented
Jul 11, 2023
| @@ -33,71 +35,71 @@ public interface SchemaChangeVisitor { | |||
| * | |||
| * @param addColumn instance of {@link AddColumn} to visit. | |||
| */ | |||
| public void visit(AddColumn addColumn); | |||
| void visit(AddColumn addColumn); | |||
There was a problem hiding this comment.
Remove redundant public modifier from interface
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.