docs: fixed broken link #933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypherpepe
requested review from
DaniPopes,
mattsse and
yash-atreya
as code owners
mattsse
reviewed
Apr 19, 2025
There was a problem hiding this comment.
we include this in lib.rs like:
core/crates/sol-types/src/lib.rs
Line 1 in 74717c0
so from that pov the link is accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The relative link to the
abimodule inREADME.mdwas broken — GitHub couldn't resolveabion its own.Switched it to
src/abiso it correctly points to the actual folder.Solution
...
PR Checklist