Skip to content

feat: added format_units_with #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025
Merged

Conversation

Rimeeeeee
Copy link
Contributor

fixes #934

@Rimeeeeee
Copy link
Contributor Author

@mattsse ,is this ok? :)

Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @mattsse

@github-project-automation github-project-automation bot moved this to Reviewed in Alloy Apr 21, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start

@github-project-automation github-project-automation bot moved this from Reviewed to In Progress in Alloy Apr 21, 2025
@Rimeeeeee Rimeeeeee requested a review from mattsse April 21, 2025 15:16
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from In Progress to Reviewed in Alloy Apr 22, 2025
@mattsse mattsse merged commit 7e050ed into alloy-rs:main Apr 22, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Alloy Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature] Add format_units_with
3 participants