Improve localisation (particularly Welsh) #417
+110
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... which now includes Welsh The `ImagePresenter` code looked like it was handling translations, but it wasn't. We don't set `I18n.locale` to anything other than English in the Govspeak code, so we need to pass the locale explicitly when calling `I18n.t`. We already do this for contacts via the `TemplateRender#t` wrapper
... which now includes Welsh. The Welsh translation is per the GOV.WALES style guide: https://www.gov.wales/govwales-style-guide
yndajas
force-pushed
the
add-footnote-translation
branch
2 times, most recently
from
7f4921d to
6f8cbd9
Compare
... which now includes Welsh. This actually simplifies some of the main Govspeak module code, removing an unnecessary class method The basic test for devolved content is in the monster `GovspeakTest` spec
yndajas
force-pushed
the
add-footnote-translation
branch
from
6f8cbd9 to
4dc1870
Compare
mike3985
approved these changes
Jun 9, 2025
|
|
||
| def initialize(image) | ||
| def initialize(image, locale) |
There was a problem hiding this comment.
This might be nicer as a named parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: verify translations added here
Trello