Add mapper 474 #54
Open
Add mapper 474 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amhndu
requested changes
Jan 4, 2025
| } | ||
| } | ||
|
|
||
| Byte MapperNROM::readPRG(Address addr) |
There was a problem hiding this comment.
Suggested change
| Byte MapperNROM::readPRG(Address addr) | |
| Byte Mapper474::readPRG(Address addr) |
Similar for the rest of the functions.
| @@ -41,13 +41,34 @@ namespace sn | |||
| } | |||
| else if (addr < 0x6000) | |||
| { | |||
| LOG(InfoVerbose) << "Expansion ROM read attempted. This is currently unsupported" << std::endl; | |||
| if (m_mapper->getType() == NROM474) | |||
There was a problem hiding this comment.
Can we get rid of the type check and simply call m_mapper? That we leave it to the mapper and the memory bus code remains generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new mapper that supports extra ROM space compared to the NROM but has no bank switching.