Skip to content

docs/projects/ad57xx_ardz: Fix DE10-Nano Linux GPIO numbers #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dlech
Copy link
Collaborator

@dlech dlech commented May 6, 2025

PR Description

According to the devicetree at 1, the GPIO numbers are starting at 16 rather than 0. That devicetree was tested on hardware, so would assume that it really is correct.

I'm also assuming that this column is for Linux, but it isn't explicit. If this column was meant for something other than Linux, then we would need to add an additional column instead.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@dlech
Copy link
Collaborator Author

dlech commented May 6, 2025

Actually, I'm realizing now that we actually also need to say which gpio controller as well. On DE10 Nano, there are lots of gpio controllers. These are using &gpio_bd which is this one.

@sarpadi sarpadi self-requested a review May 15, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants