Updated video player logic: now it pauses also when another window is occluding it #72

romanofranz · 2025-07-02T14:23:44Z

Updated video player logic: now it pauses also when another window is occluding it (in multi-window mode)

Added TrustedPresentationListener in MainActivity
Added the occlusion state to be observable from

the VideoPlayer composable

…occluding it (in multi-window mode)

gemini-code-assist

Summary of Changes

Hello @romanofranz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to the video player's behavior by making it aware of its visibility state in multi-window scenarios. By leveraging Android's TrustedPresentationListener, the application can now intelligently pause video playback when its window is not fully visible, ensuring a more intuitive and resource-efficient user experience.

Highlights

Video Playback Control: Implemented logic to automatically pause video playback when the application's window is occluded by another window, particularly in multi-window environments. This enhances user experience by preventing audio/video from playing when not visible.
Window Occlusion Detection: Integrated the TrustedPresentationListener in MainActivity to monitor the occlusion state of the application's window. This listener provides real-time updates on whether the window is fully visible or partially/fully occluded, specifically for Android 14 (API 34) and above.
State Propagation: The detected window occlusion state is now propagated from MainActivity down through the navigation and UI components (MainNavigation, HomeScreen, VideoPlayerRotatedCard) to the VideoPlayer composable, allowing it to react to visibility changes and control playback accordingly.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The code changes introduce the ability to pause the video when the app window is occluded. The review focuses on improving code readability by suggesting the use of named arguments and type-safe system service retrieval.

app/src/main/java/com/android/developers/androidify/MainActivity.kt

gemini-code-assist · 2025-07-02T14:26:09Z

app/src/main/java/com/android/developers/androidify/MainActivity.kt

+                1f, 0.25f, 500
+            )
+
+            val windowManager = getSystemService(WINDOW_SERVICE) as WindowManager


For better type safety and to avoid a potentially unsafe cast, it's recommended to use the typed getSystemService(Class<T>) method.

val windowManager = getSystemService(WindowManager::class.java)

gemini-code-assist · 2025-07-02T14:26:09Z

feature/home/src/main/java/com/android/developers/androidify/home/HomeScreen.kt

@@ -168,6 +173,7 @@ fun HomeScreenContents(
                    ) {
                        VideoPlayerRotatedCard(
                            videoLink,
+                            isWindowNotOccluded,


Consider using named arguments for better readability when calling VideoPlayerRotatedCard.

VideoPlayerRotatedCard( videoLink = videoLink, isWindowNotOccluded = isWindowNotOccluded, modifier = Modifier .padding(32.dp) .align(Alignment.Center), )

gemini-code-assist · 2025-07-02T14:26:09Z

feature/home/src/main/java/com/android/developers/androidify/home/HomeScreen.kt

@@ -198,6 +204,7 @@ fun HomeScreenContents(
                CompactPager(
                    videoLink,
                    dancingBotLink,
+                    isWindowNotOccluded = isWindowNotOccluded,


Consider using named arguments for better readability when calling CompactPager.

CompactPager( videoLink = videoLink, dancingBotLink = dancingBotLink, isWindowNotOccluded = isWindowNotOccluded, onClickLetsGo = onClickLetsGo, onAboutClicked = onAboutClicked, )

gemini-code-assist · 2025-07-02T14:26:09Z

feature/home/src/main/java/com/android/developers/androidify/home/HomeScreen.kt

@@ -239,6 +247,7 @@ private fun CompactPager(
                Box(modifier = Modifier.fillMaxSize()) {
                    VideoPlayerRotatedCard(
                        videoLink = videoLink,
+                        isWindowNotOccluded = isWindowNotOccluded,


Consider using named arguments for better readability when calling VideoPlayerRotatedCard.

VideoPlayerRotatedCard( videoLink = videoLink, isWindowNotOccluded = isWindowNotOccluded, modifier = Modifier .padding(horizontal = 32.dp) .align(Alignment.Center), )

gemini-code-assist · 2025-07-02T14:26:09Z

feature/home/src/main/java/com/android/developers/androidify/home/HomeScreen.kt

@@ -316,6 +326,7 @@ private fun VideoPlayerRotatedCard(
    ) {
        VideoPlayer(
            videoLink,
+            isWindowNotOccluded,


Consider using named arguments for better readability when calling VideoPlayer.

VideoPlayer( videoLink = videoLink, isWindowNotOccluded = isWindowNotOccluded, modifier = Modifier .aspectRatio(aspectRatio) .align(Alignment.Center) .clip(MaterialTheme.shapes.large) .clipToBounds(), )

…occluding it (in multi-window mode)

app/src/main/java/com/android/developers/androidify/MainActivity.kt

riggaroo · 2025-07-03T09:08:10Z

app/src/main/java/com/android/developers/androidify/MainActivity.kt

@@ -46,8 +52,25 @@ class MainActivity : ComponentActivity() {
                        Color.Transparent.toArgb(),
                    ),
                )
-                MainNavigation()
+                MainNavigation(isWindowNotOccluded)


I'd love for us to consider how this could potentially be accessed / used without having to pass the value all the way from the Top level composable down to where its needed. Is it possible to create a modifier that does this logic?
It would be ideal if either Modifier.onVisibilityChanged included this logic, or if we could expose a Modifier.onOccluded(), as this seems to find its way through all the composables that may not need it.

cc @lelandrichardson

Right now I went with the path of Composition Local to avoid passing the value all the way down

Update video player logic: now it pauses also when another window is …

9d6b561

…occluding it (in multi-window mode)

romanofranz requested review from tiwiz and riggaroo July 2, 2025 14:23

gemini-code-assist bot reviewed Jul 2, 2025

View reviewed changes

romanofranz added 4 commits July 2, 2025 16:40

Update video player logic: now it pauses also when another window is …

efec325

…occluding it (in multi-window mode)

Merge branch 'windowing' of github.com:android/androidify into windowing

2fcb8f7

Merge branch 'windowing' of github.com:android/androidify into windowing

dcfbc5e

Merge branch 'windowing' of github.com:android/androidify into windowing

4f5ee2c

riggaroo reviewed Jul 3, 2025

View reviewed changes

romanofranz added 2 commits July 4, 2025 12:04

Merge branch 'windowing' of github.com:android/androidify into windowing

1689425

Merge branch 'windowing' of github.com:android/androidify into windowing

666e896

riggaroo approved these changes Jul 4, 2025

View reviewed changes

romanofranz merged commit 2b830fd into main Jul 4, 2025
3 checks passed

romanofranz deleted the windowing branch July 4, 2025 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated video player logic: now it pauses also when another window is occluding it #72

Updated video player logic: now it pauses also when another window is occluding it #72

Uh oh!

romanofranz commented Jul 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Jul 2, 2025

Uh oh!

gemini-code-assist bot Jul 2, 2025

Uh oh!

gemini-code-assist bot Jul 2, 2025

Uh oh!

gemini-code-assist bot Jul 2, 2025

Uh oh!

gemini-code-assist bot Jul 2, 2025

Uh oh!

Uh oh!

riggaroo Jul 3, 2025

Uh oh!

romanofranz Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Updated video player logic: now it pauses also when another window is occluding it #72

Updated video player logic: now it pauses also when another window is occluding it #72

Uh oh!

Conversation

romanofranz commented Jul 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

riggaroo Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

romanofranz Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!