Skip to content

Remove local google-services.json file #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 4, 2025
Merged

Remove local google-services.json file #74

merged 5 commits into from
Jul 4, 2025

Conversation

riggaroo
Copy link
Collaborator

@riggaroo riggaroo commented Jul 4, 2025

Pull debug file down in build_and_test.yml workflow instead.

Add to .gitignore

…uild_and_test.yml workflow instead.

Add to .gitignore
@riggaroo riggaroo marked this pull request as ready for review July 4, 2025 11:02
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the security and maintainability of the project's Firebase configuration by removing the google-services.json file from version control. This change centralizes the management of this sensitive file within the CI/CD pipeline and updates user setup instructions accordingly.

Highlights

  • Configuration Management: The google-services.json file, which contains sensitive Firebase project configuration, is no longer committed directly to the repository. Instead, the intent is for it to be pulled down during the build_and_test.yml workflow, improving security and consistency.
  • Documentation Update: The README.md has been updated to reflect the new approach for handling google-services.json, instructing users to simply place the file in the app folder rather than replacing an existing placeholder.
  • Git Ignore Rule: A new entry for google-services.json has been added to app/.gitignore to ensure this file is not accidentally committed to the repository.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the google-services.json file from version control by adding it to .gitignore and updating the setup instructions in the README.md. This is a good practice for security and project configuration.

My review includes one suggestion to improve the clarity of the setup instructions in the README.md by fixing a link that will be broken as a result of this change.

riggaroo and others added 4 commits July 4, 2025 12:04
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@riggaroo riggaroo merged commit 179b791 into main Jul 4, 2025
3 checks passed
@riggaroo riggaroo deleted the ignore-services branch July 4, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants