-
Notifications
You must be signed in to change notification settings - Fork 103
Integrate Kermit for logging #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit introduces Kermit for logging: - Added the Kermit dependency (`co.touchlab:kermit`) to `libs.versions.toml` and `shared/build.gradle.kts`. - Replaced `println` statements with `Logger.i` in `CartViewModel` and `MainViewModel` for improved logging. - Added logging for ViewModel creation and clearing in both `CartViewModel` and `MainViewModel`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cartland, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the Kermit logging library to the Fruitties
project, transitioning from basic println
statements to a more structured and robust logging solution. The primary goal is to improve the application's debuggability and maintainability by providing consistent and informative log messages, especially concerning ViewModel lifecycle events.
Highlights
- Logging Framework Integration: I've integrated the Kermit logging library (version 2.0.4) into the project. This involved adding its dependency to
libs.versions.toml
and including it in theshared/build.gradle.kts
file. println
Statement Replacement: I've replaced directprintln
statements withLogger.i
calls in bothCartViewModel
andMainViewModel
. This standardizes logging output and leverages the capabilities of the new logging framework.- ViewModel Lifecycle Logging: I've enhanced the logging in
CartViewModel
andMainViewModel
to explicitly log their creation and clearing events. This provides better visibility into the lifecycle of these components, aiding in debugging.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully integrates the Kermit logging library. The changes correctly add the necessary dependencies and replace println
statements with Logger.i
for improved logging in CartViewModel
and MainViewModel
. The addition of logging for ViewModel creation and clearing is a good practice for debugging and understanding the lifecycle. The changes are straightforward and enhance the application's observability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right. My logs were just for testing :D
172a052
into
mlykotom/ios-viewmodel-scoping
This commit introduces Kermit for logging:
co.touchlab:kermit
) tolibs.versions.toml
andshared/build.gradle.kts
.println
statements withLogger.i
inCartViewModel
andMainViewModel
for improved logging.CartViewModel
andMainViewModel
.