App id verification #32
Conversation
…in route request if any app ids are passed in.
| @@ -50,6 +55,19 @@ def access_token(self): | |||
| def session_id(self): | |||
| return self.request["session"]["sessionId"] | |||
|
|
|||
| def application_id(self): | |||
| try: | |||
There was a problem hiding this comment.
Please replace the generic exception handling with an explicit check, or at least catch the specific exception
| class Request(object): | ||
| """ | ||
| Simple wrapper around the JSON request | ||
| received by the module | ||
| """ | ||
| def __init__(self, request_dict, metadata=None): | ||
| def __init__(self, request_dict, metadata=None, supported_app_ids=None): |
There was a problem hiding this comment.
Doesn't it make more sense to do the supported app IDs verification in the VoiceHandler object?
There was a problem hiding this comment.
sorry for late reply, been really busy, but yes it does i just made this on the quickness, didnt really think about it too much, ill make the changes.
| @@ -192,11 +210,18 @@ def _handler(func): | |||
|
|
|||
| return _handler | |||
|
|
|||
| def route_request(self, request_json, metadata=None): | |||
| def route_request(self, request_json, metadata=None, app_ids=None): | |||
There was a problem hiding this comment.
It seems to me that having the app_ids as a construction parameter for the 'alexa' makes more sense than passing it into a parameter for route_request
There was a problem hiding this comment.
i agree, should i add it to the constructor somehow? or do alexa.app_ids = [...] in lambda_handler?
hey i wrote some code to verify application ids since its needed to pass Amazon submission. Let me know if you are fine with this code or if you need me to make any changes or if you know a cleaner way of doing this.