Skip to content

[1-min] Fix output path for type defs #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2022
Merged

[1-min] Fix output path for type defs #10

merged 1 commit into from
Apr 18, 2022

Conversation

aalmazan
Copy link
Contributor

@aalmazan aalmazan commented Apr 18, 2022 •
edited
Loading

Description of the change

Fixes output path for types files (*.d.ts). lerna builds and publishes things that are in the dist directory and types were not going there.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes <add Issue here, can be in format #xx>

Dev Checklist

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

@aalmazan aalmazan requested review from benogle and newhouse April 18, 2022 21:12
@aalmazan aalmazan merged commit 18fa6a7 into main Apr 18, 2022
@aalmazan aalmazan deleted the aa/fix-types-dist branch April 18, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benogle benogle benogle approved these changes

@newhouse newhouse Awaiting requested review from newhouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalmazan @benogle