Skip to content

Add Typescript support to AnvilEmbedFrame #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add Typescript support to AnvilEmbedFrame #13

merged 1 commit into from
Oct 4, 2022

Conversation

Winggo
Copy link
Contributor

@Winggo Winggo commented Oct 4, 2022 •
edited
Loading

Description of the change

Add types to AnvilEmbedFrame released in #12

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes anvilco/public-repos#18

Dev Checklist

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

@Winggo Winggo requested a review from benogle October 4, 2022 20:21
@Winggo Winggo self-assigned this Oct 4, 2022
benogle
benogle approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@benogle benogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Winggo Winggo merged commit 099c432 into main Oct 4, 2022
@Winggo Winggo deleted the wt/add-ts branch October 4, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benogle benogle benogle approved these changes

Assignees

@Winggo Winggo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Winggo @benogle