[Breaking] Version 2.0 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @anvilco/[email protected] - @anvilco/[email protected]
- @anvilco/[email protected]
fostimus
approved these changes
Sep 20, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@anvilco/anvil-embed-frame", | |||
| "version": "1.1.0", | |||
| "version": "2.0.0-alpha.0", | |||
There was a problem hiding this comment.
good to move off the alpha version?
There was a problem hiding this comment.
probably waiting for lerna publish to handle it after merging?
There was a problem hiding this comment.
I will publish both repos after merge!
|
|
||
| * `signURL` -> `iframeURL` | ||
| * `onFinishSigning` -> `onEvent`. Check the `eventObject.action === 'signerComplete'` to detect a signer has finished signing | ||
| * `onError` -> `onEvent`. Check the `eventObject.action` to determine if there is an error |
There was a problem hiding this comment.
should be eventObject.error
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@anvilco/react-signature-modal", | |||
| "version": "1.8.4", | |||
| "version": "2.0.1-alpha.0", | |||
newhouse
approved these changes
Sep 20, 2023
|
Just the few small things in comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for both
AnvilEmbedFrameandAnviSignatureModal, see the respective readmes for upgrade instructions:AnvilSignatureModalAnvilEmbedFrameThis PR upgrades all dependencies in all
AnvilEmbedFrameandAnvilSignatureModalplusAnvilSignatureModalAnvilEmbedFrameAnvilEmbedFrameenableDefaultStylestitleattributeChanges will result in a major version bump (v2) for both components
Type of change