Add onError handler #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winggo
reviewed
Oct 26, 2021
Comment on lines
40
to
49
| it('does not call any callbacks when a string data passed in', async function () { | ||
| const origin = $.anvilURL | ||
| const data = { action: 'signerComplete' } | ||
| const wrapper = $.render | ||
| wrapper.instance().handleSignFinish({ origin, data }) | ||
| expect($.handleLoad).not.to.have.been.called | ||
| expect($.handleError).not.to.have.been.called | ||
| expect($.handleFinish).not.to.have.been.called | ||
| expect($.handleFinishSigning).not.to.have.been.called | ||
| }) |
There was a problem hiding this comment.
should be does not call any callbacks when non-string data is passed in I believe
Winggo
reviewed
Oct 26, 2021
Comment on lines
+33
to
+41
| const payload = omit(parseURLParams(searchStr), IGNORED_KEYS) | ||
| const hasError = payload.action === 'signerError' || payload.error || payload.errorType | ||
| if (!payload.action) { | ||
| payload.action = hasError ? 'signerError' : 'signerComplete' | ||
| } | ||
| if (hasError) { | ||
| onError(payload) | ||
| } else { | ||
| searchObj = JSON.parse('{"' + decodeURI(searchStr).replace(/"/g, '\\"').replace(/&/g, '","').replace(/=/g, '":"') + '"}') | ||
| hasError = searchObj.error || searchObj.errorType | ||
| payload = { | ||
| action: 'signerComplete', | ||
| signerStatus: searchObj.signerStatus ?? null, | ||
| signerEid: searchObj.signerEid ?? null, | ||
| nextSignerEid: searchObj.nextSignerEid ?? null, | ||
| documentGroupStatus: searchObj.documentGroupStatus ?? null, | ||
| documentGroupEid: searchObj.documentGroupEid ?? null, | ||
| etchPacketEid: searchObj.etchPacketEid ?? null, | ||
| weldDataEid: searchObj.weldDataEid ?? null, | ||
| } | ||
| onFinishSigning(payload) |
There was a problem hiding this comment.
So much cleaner with the helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
onErrorhandler to both components. It will emit the following payloadThis PR also adds
Type of change