Skip to content

Add Typescript typings #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Add Typescript typings #9

merged 5 commits into from
Apr 18, 2022

Conversation

aalmazan
Copy link
Contributor

@aalmazan aalmazan commented Apr 18, 2022

Description of the change

Adds Typescript typings for packages

image

image

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Closes #8

Dev Checklist

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

@aalmazan aalmazan requested review from benogle and newhouse April 18, 2022 17:54
"scripts": {
"build": "webpack --mode production",
"build:changelog": "yarn auto-changelog",
"pack": "yarn pack",
"version": "yarn build:changelog && git add CHANGELOG.md",
"test": "yarn mocha --config ./test/mocha.js"
"test": "yarn mocha --config ./test/mocha.js",
"tsc": "tsc"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah suppose not. I actually need to add that into the build script instead.

@@ -0,0 +1,34 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this looks a lot like the other one from the node-anvil?

@aalmazan aalmazan merged commit 5f4fb22 into main Apr 18, 2022
@aalmazan aalmazan deleted the aa/add-typings branch April 18, 2022 20:37
@benogle
Copy link
Contributor

benogle commented Apr 18, 2022

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using with typescript problem
3 participants