Skip to content

clean up rent code #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 8, 2025
Merged

clean up rent code #6816

merged 9 commits into from
Jul 8, 2025

Conversation

HaoranYi
Copy link

@HaoranYi HaoranYi commented Jul 2, 2025

Problem

Rent has been completely disabled on mainnet. Rent related code is no longer used. We can clean them up.

Summary of Changes

Clean up rent code.

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (f1f21ee) to head (e29bcef).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6816     +/-   ##
=========================================
- Coverage    83.3%    83.2%   -0.1%     
=========================================
  Files         853      852      -1     
  Lines      378472   376862   -1610     
=========================================
- Hits       315450   313845   -1605     
+ Misses      63022    63017      -5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HaoranYi HaoranYi requested a review from a team as a code owner July 7, 2025 15:41
@LucasSte LucasSte requested a review from brooksprumo July 7, 2025 20:59
@@ -683,6 +683,7 @@ impl<T: IndexValue, U: DiskIndexValue + From<T> + Into<T>> AccountsIndex<T, U> {
}
}

#[cfg(test)]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be #[cfg(feature = "dev-context-only-utils")]?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. updated.

Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome PR!

Lgtm, but I think you'll need to rebase and resolve conflicts due the snapshot-minimizer PR I just merged.

@HaoranYi
Copy link
Author

HaoranYi commented Jul 7, 2025

This is an awesome PR!

Lgtm, but I think you'll need to rebase and resolve conflicts due the snapshot-minimizer PR I just merged.

Rebased.

@HaoranYi HaoranYi requested a review from jstarry July 7, 2025 21:56
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@HaoranYi HaoranYi merged commit 30fa4ae into anza-xyz:master Jul 8, 2025
41 checks passed
@HaoranYi HaoranYi deleted the cleanup_rent branch July 8, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants