-
Notifications
You must be signed in to change notification settings - Fork 590
clean up rent code #6816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up rent code #6816
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6816 +/- ##
=========================================
- Coverage 83.3% 83.2% -0.1%
=========================================
Files 853 852 -1
Lines 378472 376862 -1610
=========================================
- Hits 315450 313845 -1605
+ Misses 63022 63017 -5 🚀 New features to boost your workflow:
|
accounts-db/src/accounts_index.rs
Outdated
@@ -683,6 +683,7 @@ impl<T: IndexValue, U: DiskIndexValue + From<T> + Into<T>> AccountsIndex<T, U> { | |||
} | |||
} | |||
|
|||
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be #[cfg(feature = "dev-context-only-utils")]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome PR!
Lgtm, but I think you'll need to rebase and resolve conflicts due the snapshot-minimizer PR I just merged.
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
Rent has been completely disabled on mainnet. Rent related code is no longer used. We can clean them up.
Summary of Changes
Clean up rent code.
Fixes #