Implement BufRead for accounts_db BufferedReader #6827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BufferedReader
uses a custom API to implement the same access pattern asBufRead
trait (though it also relaxes some of its constraints and adds a couple of extensions).The custom API makes it harder to understand and reason about, but also it's harder to implement/substitute with an alternative implementation (e.g. io_uring read-ahead buffered reader).
Summary of Changes
BufferedReader
provides all the functionality ofBufRead
, so the custom API is converted to use offill_buf
andconsume
. The extra functionality like access to current offset and setting min required data is kept as pub API ofBufferedReader
(when alternative impl is available, those should be elevated to separete trait that will extendBufRead
).