Skip to content

v2.3: xdp: set ring sizes based on configured ethtool values (backport of #6826) #6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 3, 2025

This queries the size of the rings using the ioctl equivalent of ethtool -g <iface>.

This is a prerequisite for a follow up PR that will always populate the fill ring to avoid driver bugs.


This is an automatic backport of pull request #6826 done by Mergify.

@mergify mergify bot added the conflicts label Jul 3, 2025
@mergify mergify bot requested a review from a team as a code owner July 3, 2025 17:39
Copy link
Author

mergify bot commented Jul 3, 2025

Cherry-pick of 032a100 has failed:

On branch mergify/bp/v2.3/pr-6826
Your branch is up to date with 'origin/v2.3'.

You are currently cherry-picking commit 032a100c6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   xdp/src/tx_loop.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   xdp/src/device.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@alessandrod alessandrod force-pushed the mergify/bp/v2.3/pr-6826 branch from 98dc665 to 3bc0595 Compare July 4, 2025 15:23
@alessandrod
Copy link

why backport: this is a prerequisite for #6846

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (5c77e1e) to head (6feeee7).

Additional details and impacted files
@@            Coverage Diff            @@
##             v2.3    #6835     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         850      850             
  Lines      379646   379684     +38     
=========================================
- Hits       314518   314499     -19     
- Misses      65128    65185     +57     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessandrod alessandrod requested a review from bw-solana July 7, 2025 03:28
* xdp: add DeviceQueue::ring_sizes()

Allows to query the size of the rings

* xdp: set ring sizes based on configured ethtool values

(cherry picked from commit 032a100)
@alessandrod alessandrod force-pushed the mergify/bp/v2.3/pr-6826 branch from 3bc0595 to 6feeee7 Compare July 7, 2025 15:16
@alessandrod alessandrod merged commit 5a7a35e into v2.3 Jul 8, 2025
69 of 86 checks passed
@alessandrod alessandrod deleted the mergify/bp/v2.3/pr-6826 branch July 8, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants