Skip to content

Removing cached items from the reclaims returned by upsert #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

roryharr
Copy link

@roryharr roryharr commented Jul 3, 2025

Problem

Cached accounts index entries are populated in reclaims, but then filtered before reclaiming. This causes needless memory allocations

Summary of Changes

  • Do not populate reclaims if items are cached
  • Do not filter out cached items from reclaims (as they are no longer present)

Note: This path is unused now as reclaims are never enabled but it will be used with obsolete accounts

Fixes #

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (5c9878b) to head (3a2eb16).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6837     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         853      853             
  Lines      378266   378258      -8     
=========================================
- Hits       315417   315376     -41     
- Misses      62849    62882     +33     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roryharr roryharr requested review from HaoranYi and brooksprumo July 3, 2025 20:50
@roryharr roryharr marked this pull request as ready for review July 3, 2025 20:51
brooksprumo
brooksprumo previously approved these changes Jul 3, 2025
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Either handle the comment request in this PR or a follow up PR.

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find. lgtm.

@roryharr roryharr merged commit 819e693 into anza-xyz:master Jul 7, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants