Skip to content

Support closing connections when QUIC connection drop #6857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lijunwangs
Copy link

Problem

When we increase connection idle time out, the connections opened in earlier connection cache instance will take longer time to reach timeout and close. This cause problems for applications recreating connection cache in lower level APIs. As their new connection attempt are blocked by connection limit per peer.

Summary of Changes

This support gracefully closing the client connections when the connection cache is dropped.

Fixes #

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (4439a5e) to head (b1deab0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6857   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         853      853           
  Lines      378270   378296   +26     
=======================================
+ Hits       315267   315334   +67     
+ Misses      63003    62962   -41     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants