Skip to content

v2.3: Recalculates the accounts lt hash when creating minimized snapshots (backport of #6843) #6872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 7, 2025

Problem

If a minimized snapshot is created, and the accounts lt hash feature is enabled, the new snapshot will fail to load because the initial startup accounts verification will fail.

This is because the accounts lt hash in the snapshot will be the pre-minimized value, based on the pre-minimized account state. If the account state is changed—as it is when creating a minimized snapshot—then then accounts lt hash must be recalculated.

Summary of Changes

Recalculate the accounts lt hash when creating a minimized snapshot.

Justification to Backport

The bug exists in all versions that support both creating minimized snapshots and the accounts lt hash feature, which includes v2.3.


This is an automatic backport of pull request #6843 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner July 7, 2025 21:01
@brooksprumo brooksprumo requested review from HaoranYi and apfitzge July 7, 2025 21:09
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (5c77e1e) to head (64b5400).

Additional details and impacted files
@@           Coverage Diff            @@
##             v2.3    #6872    +/-   ##
========================================
  Coverage    82.8%    82.8%            
========================================
  Files         850      850            
  Lines      379646   379739    +93     
========================================
+ Hits       314518   314686   +168     
+ Misses      65128    65053    -75     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brooksprumo brooksprumo merged commit e3abf6b into v2.3 Jul 7, 2025
46 checks passed
@brooksprumo brooksprumo deleted the mergify/bp/v2.3/pr-6843 branch July 7, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants