Renames AccountsFile::append_accounts() to write_accounts() #6879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
accounts/write-accounts
branch
from
613a8d1 to
cfbcfb6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6879 +/- ##
=========================================
- Coverage 83.3% 83.2% -0.1%
=========================================
Files 853 852 -1
Lines 378508 376898 -1610
=========================================
- Hits 315483 313856 -1627
- Misses 63025 63042 +17 🚀 New features to boost your workflow:
|
roryharr
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AccountsFile::append_accounts()is misleading, as it is not legal to call this function multiple times. If using TieredStorage, this fn will panic.Summary of Changes
Rename to
write_accounts().