remove unused SnapshotMinimizer::ending_slot

[HaoranYi]

Problem

SnapshotMinimizer::ending_slot used to be required for snapshot_minimizer due to rent collection. Now rent collection is disabled. ending_slot is no longer needed for snapshot_minimizer.

Summary of Changes

remove ending_slot from snapshot_minimizer.

Fixes #

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (fca11d3) to head (0baa0ed).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #6880     +/-   ##
=========================================
- Coverage    83.3%    83.2%   -0.1%     
=========================================
  Files         853      852      -1     
  Lines      378508   376882   -1626     
=========================================
- Hits       315483   313861   -1622     
+ Misses      63025    63021      -4     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[brooksprumo]

Removing @jstarry and adding @apfitzge as a reviewer, since @apfitzge is this code's owner.

[apfitzge]

This can't be true. If it's the case in the code ending slot was only used for rent collection, something fundamental has broken about snapshot minimization.

The whole process of minimization is to minimize a snapshot at slot N by keeping only enough state to replay until some later ending slot.
Without the ending slot this process doesn't even make sense.

edit: I see now. this removes it from SnapshotMinimizer NOT from snapshot minimization in ledger-tool.

[brooksprumo]

I'm kinda surprised that we don't need the ending slot anymore, as I thought that would impact the accounts kept/pruned. I'll defer to @apfitzge here.

[HaoranYi]

edit: I see now. this removes it from SnapshotMinimizer NOT from snapshot minimization in ledger-tool.

yes. snapshot minimizer doesn't need it any more. no rent update, so no end slot needed.

[apfitzge]

@HaoranYi minor. Can you update the title to be something like:

remove unused SnapshotMinimizer::ending_slot

the field name in title doesn't match the actual field name rn

[apfitzge]

Left a minor comment about the title.

As I mentioned in a previous comment, this PR removes ending_slot from the SnapshotMinimizer but not from the minimization process. ending_slot is still required to be passed into ledger-tool to figure out which accounts are touched in transactions in [snapshot_slot, ending_slot] range.

[HaoranYi]

Left a minor comment about the title.

As I mentioned in a previous comment, this PR removes ending_slot from the SnapshotMinimizer but not from the minimization process. ending_slot is still required to be passed into ledger-tool to figure out which accounts are touched in transactions in [snapshot_slot, ending_slot] range.

updated.

[brooksprumo]