Refactors Bank::set_capitalization() #6883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
capitalization/set
branch
from
bc890f6 to
dcbad51
Compare
roryharr
approved these changes
Jul 8, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6883 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 852 852
Lines 376952 376951 -1
=========================================
- Hits 313916 313879 -37
- Misses 63036 63072 +36 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank::set_capitalization()is strange because it doesn't do what is expected of aset_xx()function. It calculates the new capitalization, then updates it. Why?More context: #6867 (comment)
Summary of Changes
Have
set_capitalization()take a capitalization parameter instead.