Fix turbine to sign last fec set if last slot in entry #6887
+164
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LOCK instead of hardcoding 64.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6887 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 852 852
Lines 376951 377027 +76
=========================================
- Hits 313888 313876 -12
- Misses 63063 63151 +88 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Addressing issue #6698
Turbine creates more resigned shreds than necessary
Summary of Changes
Changed make_shreds_from_data to have only last fec_set signed if last in slot. Updated unit tests to only check fec_set when last in slot.