Updates docs for Bank::set_capitalization() #6890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
capitalization/doc
branch
from
31b70ed to
57dc933
Compare
brooksprumo
commented
Jul 8, 2025
| /// (cannot be made DCOU due to snapshot-minimizer) | ||
| pub fn set_capitalization(&self, capitalization: u64) { | ||
| /// (cannot be made DCOU due to solana-program-test) | ||
| pub fn set_capitalization_for_tests(&self, capitalization: u64) { |
There was a problem hiding this comment.
The _for_tests suffix is the idiomatic naming in the monorepo.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6890 +/- ##
========================================
Coverage 83.2% 83.2%
========================================
Files 852 852
Lines 376951 377017 +66
========================================
+ Hits 313888 314005 +117
+ Misses 63063 63012 -51 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank::set_capitalization() and Bank::calculate_capitalization() should be DCOU, but solana-program-test currently prevents that. The doc comments should indicate as such, and we can rename the fns to make that clear.
Summary of Changes
Update the docs and rename the fns so it is clear they should only be called by tests/dcou.