new token bucket impl #6893
new token bucket impl #6893
Conversation
alexpyattaev
added
CI
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6893 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 856 856
Lines 376837 377166 +329
=========================================
+ Hits 313736 313969 +233
- Misses 63101 63197 +96 🚀 New features to boost your workflow:
|
|
|
||
| /// Provides rate limiting for multiple source IP addresses | ||
| /// on demand. Uses LazyLru under the hood. | ||
| pub struct KeyedRateLimiter { |
There was a problem hiding this comment.
Shouldn't it be Sync+Send if we want to use it in different tasks? I'm not sure if LazyLru is.
There was a problem hiding this comment.
probably yes, will work on it.
There was a problem hiding this comment.
Done in adcf32e The implementation is kinda naive and performance is not amazing, but it is simpler and also accurate (unlike the governor crate based impl)
| /// Provides rate limiting for multiple source IP addresses | ||
| /// on demand. Uses LazyLru under the hood. | ||
| pub struct KeyedRateLimiter { | ||
| data: RwLock<LruCache<IpAddr, TokenBucket>>, |
There was a problem hiding this comment.
yeah, governer is using DashMap<IpAddr, Atomicu64> and i think we do something similar here for the performance sake (depends on when do we need this, of course).
There was a problem hiding this comment.
Yeah switching to a sharded hashmap would be the most obvious thing to optimize. Time to fork LazyLRU?
alexpyattaev
force-pushed
the
ratelimiter
branch
2 times, most recently
from
4579fe3 to
aa91a89
Compare
alexpyattaev
force-pushed
the
ratelimiter
branch
from
aa91a89 to
58d47a2
Compare
Problem
Summary of Changes