Skip to content

Remove index_in_caller and index_in_callee from InstructionAccount #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LucasSte
Copy link

@LucasSte LucasSte commented Jul 9, 2025

Problem

Summary of Changes

Depends on #6829

Copy link

mergify bot commented Jul 9, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@LucasSte LucasSte force-pushed the ix-acc-2 branch 5 times, most recently from f9f43b0 to f098308 Compare July 14, 2025 19:34
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.81818% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (4807a7a) to head (617622d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6902   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         856      856           
  Lines      376390   376466   +76     
=======================================
+ Hits       313281   313347   +66     
- Misses      63109    63119   +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants