Skip to content

clippy: uninlined_format_args (ledger-tool) #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025

Conversation

steviez
Copy link

@steviez steviez commented Jul 10, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

Fix uninlined_format_args warnings in ledger-tool + format strings to ensure any changes remain compliant with 100 character line width limit

The string formatting was previously done with below PR, but clearly not having that setting persisted in our config allowed more stuff to creep in:
solana-labs#34284

@steviez steviez changed the title clippy: uninlined_format_args for ledger-tool clippy: uninlined_format_args (1 / N) Jul 10, 2025
@steviez steviez changed the title clippy: uninlined_format_args (1 / N) clippy: uninlined_format_args (ledger-tool) Jul 10, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (87451d5) to head (63b45d4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6909   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         852      852           
  Lines      377089   377089           
=======================================
+ Hits       314051   314079   +28     
+ Misses      63038    63010   -28     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez requested a review from cpubot July 10, 2025 05:57
Copy link

@cpubot cpubot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steviez steviez merged commit 2dcf895 into anza-xyz:master Jul 10, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_ledger-tool branch July 10, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants