Scan accounts panics if get_account_accessor returns Cached(None) #6929
Conversation
| let account_slot = self | ||
| .get_account_accessor(slot, pubkey, &account_info.storage_location()) | ||
| .get_loaded_account(|loaded_account| { | ||
| let mut account_accessor = |
There was a problem hiding this comment.
Cached(None) can occur in two situations:
- The account is flushed from cache to storage between scan_accounts finding the account, and get_account_accessor being called
- The slot/account is removed entirely between scan_accounts finding the account and get_account_accessor being called.
Both cases result in a panic with the current code. This modifies both cases to be errors, at which point another RPC call can be done.
It might be better to handle the first case explicitly, but that would be a larger change, and this is better than the existing behaviour in both scenarios.
The other option considered was using retry_to_get_account_accessor, but that still results in a panic in scenario 2.
roryharr
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6929 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 853 853
Lines 377591 377593 +2
=========================================
- Hits 314527 314520 -7
- Misses 63064 63073 +9 🚀 New features to boost your workflow:
|
|
In general I would like to add a sleep to get_account_accessor, but I can't do that in this PR as there are other bugs to resolve first. |
|
lgtm. |
Problem
get_loaded_account expects that the account accessor refers to a valid entry. This may not be the case during scan_accounts as it can run concurrently with flush_write_cache.
Summary of Changes
Modified scan_accounts to return an error when a Cached(None) account accessor is found.
Fixes #